Skip to content

Remove unused native libs from opencv#12021

Merged
Akirathan merged 4 commits intodevelopfrom
wip/akirathan/strip-native-libs
Jan 10, 2025
Merged

Remove unused native libs from opencv#12021
Akirathan merged 4 commits intodevelopfrom
wip/akirathan/strip-native-libs

Conversation

@Akirathan
Copy link
Contributor

@Akirathan Akirathan commented Jan 8, 2025 •
edited
Loading

Follow-up of #11874

Pull Request Description

Remove all opencv's native libs that are unused - native libs for different operating systems and architectures. Leave only a single native lib that is used. Should reduce size of the relase by roughly 300 MB.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 8, 2025
@Akirathan Akirathan self-assigned this Jan 8, 2025
hubertp
hubertp reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/enso-org/enso/blob/develop/app/ide-desktop/client/tasks/signArchivesMacOs.ts#L138 can be updated as well?

JaroslavTulach
JaroslavTulach approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI holds together...

@enso-bot enso-bot bot mentioned this pull request Jan 8, 2025
Closed
@Akirathan
Copy link
Contributor Author

Akirathan commented Jan 9, 2025 •
edited by unfurl-links bot
Loading

https://github.com/enso-org/enso/blob/develop/app/ide-desktop/client/tasks/signArchivesMacOs.ts#L138 can be updated as well?

@hubertp Good idea. Done that in c9003a0. Do you know if it is possible to test the signing process on this PR?

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - enso-org/enso

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 9, 2025
@Akirathan
Copy link
Contributor Author

Akirathan commented Jan 9, 2025 •
edited
Loading

Nightly release scheduled at https://github.com/enso-org/enso/actions/runs/12694166284

@enso-bot enso-bot bot mentioned this pull request Jan 9, 2025
Closed
somebody1234
somebody1234 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving changes to signArchivesMacOs.ts

@Akirathan
Copy link
Contributor Author

Akirathan commented Jan 10, 2025 •
edited
Loading

Sizes of .exe, .dmg and .AppImage got down roughly by 70 MB. Mac signing seems to work.

@Akirathan
Copy link
Contributor Author

Akirathan commented Jan 10, 2025 •
edited
Loading

Standard.Image on https://github.com/enso-org/enso/releases/tag/2025.1.1-nightly.2025.1.9.1 works on Linux and on Windows. Mac cannot be tested at the moment, because all the nightly releases are failing since mid December. Let's integrate.

GitHub
Download Enso IDE Enso IDE is the main product of the Enso project. The packages are stand-alone, they contain both GUI and the backend. Download links:

Windows
Linux
macOS (Intel)
macOS (Apple si...

@Akirathan Akirathan merged commit 354ccce into develop Jan 10, 2025
56 checks passed
@Akirathan Akirathan deleted the wip/akirathan/strip-native-libs branch January 10, 2025 13:26
@hubertp hubertp mentioned this pull request Jan 29, 2025
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Feb 1, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hubertp hubertp hubertp left review comments

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu

@indiv0 indiv0 Awaiting requested review from indiv0

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount

+1 more reviewer

@somebody1234 somebody1234 somebody1234 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Akirathan Akirathan

Labels

CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Akirathan @hubertp @somebody1234 @JaroslavTulach